PHPLIB-1702: Ensure withOptions preserves autoEncryptionEnabled #1747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
approved these changes
Aug 13, 2025
GromNaN
reviewed
Aug 13, 2025
Comment on lines
+140
to
+142
| /* Database and Collection objects may need to know whether auto | ||
| * encryption is enabled for dropping collections. Track this via an | ||
| * internal option until PHPC-2615 is implemented. */ |
There was a problem hiding this comment.
I really like this kind of comment that gives context and reference.
This was referenced Aug 13, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-1702
This is something I came across while working on the merge-up PR (#1746). It can be reviewed independently.